endroid / qr-code

QR Code Generator
https://endroid.nl
MIT License
4.42k stars 726 forks source link

Feature request: support multiple QR code configurations #74

Closed gremo closed 3 years ago

gremo commented 7 years ago

Hi there! Great library! What about moving the Symfony bundle in another package? In addition, I would add more configuration like this:

endroid_qr_code:
    my_qr1:
        size: 100
        padding: 10
        extension: gif
        error_correction_level: medium
        foreground_color: { r: 0, g: 0, b: 0, a: 0 }
        background_color: { r: 255, g: 255, b: 255, a: 0 }
        label: 'My label'
        label_font_size: 16
    myqr2:
        size: 250
        padding: 10
        error_correction_level: high
    # ...
$this->get('endroid_qrcode.myqr2')->createQrCode();
LaurentMarquet commented 7 years ago

It seems that it has been abandoned: https://github.com/endroid/EndroidQrCodeBundle, but thanks for having asked this question, like this, I've been able to update my code to the main library.

endroid commented 7 years ago

Hi @gremo I think it is indeed better practice to separate the bundle but I decided to put the bundle in the library for reasons of maintainability and I think I will keep it that way unless I experience issues with this set up.

I think it's a good idea to support multiple configurations. I will try to incorporate this any time soon. Of course you can also create a PR for this if you like. I will rename the title and categorize this issue as enhancement.

Thank you!

gremo commented 7 years ago

@endroid I'll work on PR, but I think you should reconsider to suppor that bundle. I can collaborate in my spare time.

endroid commented 7 years ago

@gremo I will decide before July on whether to maintain a separate repository for the bundle or not. For now it resides in the library. Please let me know if the current set up gives you any problems.

Spomky commented 7 years ago

Please read https://speakerdeck.com/fabpot/a-monorepo-vs-manyrepos. You can have one monolithic repository you can split easily with https://github.com/splitsh/lite

endroid commented 7 years ago

Thank you, I will look at it.

endroid commented 3 years ago

This is possible since the 4.0.0 release.