Closed rd003 closed 1 year ago
Name | Link |
---|---|
Latest commit | 614874d48526e463ac51237fdd1f7856f62a57ae |
Latest deploy log | https://app.netlify.com/sites/ngx-libs/deploys/64b96b33978c9200086e262b |
Deploy Preview | https://deploy-preview-29--ngx-libs.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Hello @rd003 Because this other PR https://github.com/eneajaho/ngx-libs/pull/20 also adds ngx-infinite-scroll, would it be okay if you update to add only the primeng one?
Okey, sure
On Thu, 20 Jul 2023, 9:30 pm Enea Jahollari, @.***> wrote:
Hello @rd003 https://github.com/rd003 Because this other PR #20 https://github.com/eneajaho/ngx-libs/pull/20 also adds ngx-infinite-scroll, would it be okay if you update to add only the primeng one?
— Reply to this email directly, view it on GitHub https://github.com/eneajaho/ngx-libs/pull/29#issuecomment-1644189660, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADTFFAPHLX23MGDKU6L4WKLXRFIYRANCNFSM6AAAAAA2RULEFU . You are receiving this because you were mentioned.Message ID: @.***>
Now I have removed ngx-infinite-scroll
Can you rebase please. There are merge conflicts.
It is my first PR in life. I have added
primeng
andngx-infinite-scroll
libraries.ngx-infinite-scroll
does not have proper github release tags,so I have added npm links prior to version.