eneim / toro

Video list auto playback made simple, specially built for RecyclerView
Apache License 2.0
1.41k stars 253 forks source link

Using Toro + ExoPlayer in Dynamic Feature Module #492

Open wintermoon9 opened 4 years ago

wintermoon9 commented 4 years ago

I'm trying to build these dependencies in my build.gradle file for a dynamic feature module.

implementation "im.ene.toro3:toro:3.7.0.2010003"
implementation "im.ene.toro3:toro-ext-exoplayer:3.7.0.2010003"

I am getting this error:

/Users/wintermoon9/Desktop/project/project-android/app/src/main/AndroidManifest.xml:22:5-25:65: AAPT: error: resource integer/google_play_services_version (aka life.company.project:integer/google_play_services_version) not found.

I'm not using google play services for anything so I'm wondering if toro is? I found this question on stack that is similar to what I'm experiencing but not related to Toro.

https://stackoverflow.com/questions/45074545/not-able-launch-android-instant-app-with-google-play-services-maps-basically

Toro itself builds fine in the dynamic feature module but it's only the toro-ext-exoplayer dependency that screws everything up.

Any suggestions?

Thank you :)

wintermoon9 commented 4 years ago

Any ideas ?