FIXED! now uses mobile api; removed py2 compatibility

enen92 / plugin.video.rtpplay

RTP Play Video Addon for KODI Entertainment Center

Other

30 stars 13 forks source link

FIXED! now uses mobile api; removed py2 compatibility #38

Closed guipenedo closed 3 years ago

guipenedo commented 3 years ago

The plugin was heavily recoded. It now uses the mobile api to get all the data, which allowed me to remove beautifulsoup from the dependencies and to improve a whole bunch of different details. I've also removed py2 support as I wasn't able to install the plugin on my local kodi with it (hope this is ok, @enen92). I've also disabled estudaremcasa, at least for now, as I didn't have time to look into it just yet

enen92 commented 3 years ago

Hum we have actions to auto submit to both Leia and matrix. I am fine with dropping py2 support (it should die in fire :) ) but we need to adjust the CI on a follow-up commit (and mark Leia as broken too). I'll take a look into this tomorrow. The lib module can probably be moved to a script.module in some future version. Thanks a lot for your time developing this!

guipenedo commented 3 years ago

Yeah I actually had started working on this months ago but gave up because of the inability to install the lib module through pip for kodi... When I got back into it I just copied the files but I agree a script module would be better

enen92 commented 3 years ago

@guipenedo submitted a new release in https://github.com/xbmc/repo-plugins/pull/3759 Krypton/python2 will be marked as broken in https://github.com/xbmc/repo-plugins/pull/3760

While testing your changes I made the following changes:

separate live tv and live radio in their own sections (i dont like the dummy listitems radio/tv they can look awful in some skins). Also the user likely wants to either watch tv or radio.
remove some python2 leftovers (coding shebangs and dummy init files)
Fixed an error with search with support for pagination. In this one I had to change the signatures of one of the api methods. you might want to cherry-pick changes to the module so they are kept in sync (see https://github.com/enen92/plugin.video.rtpplay/commit/a67685237b5ff3218a31e445f89463995dc6eaa9)

thanks again for the reverse work :) added you as a project collaborator

guipenedo commented 3 years ago

Thank you for making me collaborator and for the fixes :) Regarding the search, the one_page parameter was already the page, as in if this is non 0 only the page with number one_page is returned. I have commented on this in https://github.com/enen92/plugin.video.rtpplay/commit/a67685237b5ff3218a31e445f89463995dc6eaa9#commitcomment-58136907