search

enen92 / screensaver.atv4

Apple aerial screensavers (apple tv 4) for Kodi
GNU General Public License v2.0
52 stars 10 forks source link

Video player doesn't use refresh rate adaption setting #13

Closed DOCaCola closed 7 years ago

DOCaCola commented 7 years ago

The video player ignores the Settings -> Player -> Videos -> Adjust display refresh rate setting. With this setting enabled, when the screensaver starts, the TV should switch to 30hz as the atv video is 30fps. Currently the monitor stays at 60hz, which is the default setting chosen in the system settings. Honoring this setting would lead to lower CPU usage, especially on lower end devices while the screensaver plays. In my case it also leads to issues where the image enhancements of my TV cannot properly handle the 30fps content playing at 60hz resulting in studdering frames.

Edit: This was a misconfiguration on my end. Not a bug with Aerial. The issue also occurred with normal playback. It was fixed by adding custom refreshrate fallbacks in the advancedsettings.xml

tremby commented 7 years ago

I was under the impression that a monitor refresh rate of 60Hz was totally fine for 30Hz video -- it'd just show each video frame for two refresh cycles of the monitor, which as far as I can tell would end up with exactly the same result as a 30Hz refresh cycle. It's when the monitor refresh rate is not an exact multiple of the video frame rate that you have stuttering issues. I wouldn't have thought it'd have any effect on CPU usage either. Please correct me if I'm wrong about any of this.