enen92 / screensaver.atv4

Apple aerial screensavers (apple tv 4) for Kodi
GNU General Public License v2.0
52 stars 10 forks source link

update for py3 and kodi 19 compatibility #46

Closed graysky2 closed 3 years ago

graysky2 commented 3 years ago

also chmod -x several files that do not need this flag

graysky2 commented 3 years ago

I believe this fixes https://github.com/enen92/screensaver.atv4/issues/45

aerickson commented 3 years ago

Confirmed working for me. Thanks!

kubedzero commented 3 years ago

Confirmed working for me as well.

Thanks @graysky2 for digging into this and providing a solution! Hopefully @enen92 can merge this soon so users don't have to go to Github and patch the files manually.

enen92 commented 3 years ago

it doesn't fix https://github.com/enen92/screensaver.atv4/issues/45 There's far more to do than just adjusting the xbmc.python version in addon.xml

graysky2 commented 3 years ago

it doesn't fix #45 There's far more to do than just adjusting the xbmc.python version in addon.xml

I am running your latest git commit and am finding it to be fully functional on 19.0.

kubedzero commented 3 years ago

finding it to be fully functional on 19.0.

Same! Though I'm working on some other changes, and will hopefully have a PR soon.

enen92 commented 3 years ago

@kubedzero a new version was submitted to matrix, if you plan to work on features make sure you use the current master

kubedzero commented 3 years ago

@enen92 I'm disappointed you didn't push the commits earlier, this undoes a lot of the work I've done in the past day 🤣

I guess I'll look at the new code and see what still needs fixing.