search

enen92 / screensaver.kaster

A chromecast-like screensaver for Kodi
GNU General Public License v2.0
25 stars 13 forks source link

use xbmcvfs to open images.json #2

Closed InuSasha closed 6 years ago

InuSasha commented 6 years ago

The open function, does only work on local machine. With xbmcvfs, it does work over nfs and co, too.

novoid commented 6 years ago

@InuSasha In line 41 of https://github.com/enen92/screensaver.kaster/pull/2/commits/de3661fd084cdd433758a05779a8b77784fa7c57, I do think there is a line break missing: f.close() for _file in files:

You might want to change this before merging.

InuSasha commented 6 years ago

@novoid this is fixed with the second commit.

novoid commented 6 years ago

Sorry, you're absolutely right. I somehow thought the second commit is in a different file.

enen92 commented 6 years ago

Thanks @InuSasha

InuSasha commented 6 years ago

@enen92 is there a planned release date, for it?

enen92 commented 6 years ago

I am quite busy atm but if you can submit the update to the oficial Repo (with a version bump) i'll accept it