eneoli / flakeshot

A screenshot tool for unix-systems which runs natively on Wayland and X11!
GNU General Public License v2.0
20 stars 1 forks source link

Basic Drawable framework + cropping #88

Closed eneoli closed 8 months ago

eneoli commented 8 months ago

Things added:

Closes #64 Closes #92

TornaxO7 commented 8 months ago

Some issues on X11

If those errors are only appearing on X11, then we can create an extra and extra PR.

Dual monitor setup with vertical monitor

image

crate::backends::create_screenshots gives me the following image:

![image](https://github.com/eneoli/flakeshot/assets/50843046/27b0b2d5-7f1c-4487-bd07-047d5ac6b6c3)

Does flakeshot create the same image with wayland and can you reproduce this?

Normal dual monitor setup from left to right

image

And even if I just have more than one monitor, I'm getting this artifact in my left monitor: image

Also trying to creating the cropping area from the left monitor to the right gives me:

image

eneoli commented 8 months ago

In relation to the X11 issue: Yes, it seems to occur exclusively on X11; Wayland functions correctly on my system. Could you please provide me with your monitor coordinates? Also which one is your primary monitor?

Regarding the second error: I'll attempt to replicate this in an X11 environment later today. Do the artifacts disappear after you stop moving the mouse or release the mouse button?

TornaxO7 commented 8 months ago

In relation to the X11 issue: Yes, it seems to occur exclusively on X11;

ooof

Could you please provide me with your monitor coordinates?

You can also do:

![image](https://github.com/eneoli/flakeshot/assets/50843046/313c6e9b-153c-4567-9e96-7d7f7a025711)

Also which one is your primary monitor?

it's the HDMI monitor

Do the artifacts disappear after you stop moving the mouse or release the mouse button?

no, they don't disappear.

eneoli commented 8 months ago

You can also do:

?

TornaxO7 commented 8 months ago

You can also do:

?

Click on "details"

eneoli commented 8 months ago

Still ? That would exactly match your screenshot.

eneoli commented 8 months ago

Also create_screenshots creates a separate image per monitor.

eneoli commented 8 months ago

@TornaxO7 there were errors in the X11 screenshot backend. You might want try it again now.

TornaxO7 commented 8 months ago

Nice one! But I've still got some issues.

Extending cropping to second monitor isn't visible

Layout: image

If I try to extend the cropping selection between two monitors, then it'll look like this: image

Setting second monitor vertical creates wrong image placing

Layout: image

Gives me this: image

To be fair, we can apply a fix for this in another PR. What do you think?

eneoli commented 8 months ago
eneoli commented 8 months ago

Blocked until https://github.com/gtk-rs/gtk4-rs/issues/1597 resolved...