search

energia / Energia

Fork of Arduino for the Texas Instruments LaunchPad's
http://energia.nu
Other
798 stars 671 forks source link

About the clear() function #1021

Closed rei-vilo closed 6 years ago

rei-vilo commented 6 years ago

Shouldn't the clear() function be simply

void LCD_SharpBoosterPack_SPI::clear()
{
    clearBuffer();
    flush();
}

instead of https://github.com/energia/Energia/blob/024a8fe8728a6e5af4e57832e36c0be43716f841/libraries/LCD_SharpBoosterPack_SPI/LCD_SharpBoosterPack_SPI.cpp#L178-L205

as clearBuffer() takes the reverse mode into account.

StefanSch commented 6 years ago

You are right, has the same result but much easier and less code. (Will put this into the code with all other updates.)

Thanks!