search

energia / msp430-lg-core

15 stars 12 forks source link

byte ordering for 16-bit #115

Closed eurol closed 5 years ago

eurol commented 5 years ago

if (UCBSM) MSB..LSB else LSB..MSB

eurol commented 5 years ago

Thanks for this. I changed these lines in my "master" branch. But what should I do now with this merge request?

StefanSch commented 5 years ago

Thanks for the update - will trigger a merge request after another review. Need also to check and updated the versions for USCI and USI

eurol commented 5 years ago

Ooops!   Sorry, it is my fault. I still have no experience using github desktop or git. I just typed changes into web version of github so it is just a mistake.   Yes, it is UCMSB.   BTW, I looked into usi_spi.cpp. There is a workaround of USI5. It looks very strange (errata too). I suggest to change workaround. Will write later.

Пятница, 27 сентября 2019, 11:14 +03:00 от StefanSch notifications@github.com:   @StefanSch commented on this pull request. Hi, you are using UCBSM but this is not a valid bit name it should be UCMSB. Just wondering how you got this compiled? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub , or mute the thread .    

Евгений Рябов