search

energia / msp430-lg-core

15 stars 12 forks source link

MSP430FR5739 Conflicting Pins Definitions #52

Closed rei-vilo closed 6 years ago

rei-vilo commented 6 years ago

Lines 84-86 and 92-94 are conflicting on pins_energia.h for MSP430FR5739.

https://github.com/energia/msp430-lg-core/blob/0bb691fce4bddcc47c67e6e951cefe6d4ae955e6/variants/MSP-EXP430FR5739LP/pins_energia.h#L84-L86

and

https://github.com/energia/msp430-lg-core/blob/0bb691fce4bddcc47c67e6e951cefe6d4ae955e6/variants/MSP-EXP430FR5739LP/pins_energia.h#L92-L94

Using AnalogRead(ACC_X) doesn't return a valid value, AnalogRead(16) does.

robertinant commented 6 years ago

It should be: 

static const uint8_t ACC_X  = 16; /* (A6) 16 - P3.0 */
static const uint8_t ACC_Y  = 17; /* (A5) 17 - P3.1 */
static const uint8_t ACC_Z  = 18; /* (A4) 18 - P3.0 */

The naming of the analog channels on the headers does not follow the name of the actual MSP430 analog channels. e.g. P3.0 is A12 for the MSP430 but is named A6 for the LaunchPad headers. Not sure what the motivation was 4 years ago but unfortunately it can not be changed. What can be changed is the ACC_X, ACC_Y and ACC_Z. If agreed on the above I will make the change and push it.

rei-vilo commented 6 years ago

Great, see pull-request https://github.com/energia/msp430-lg-core/pull/53.