search

energia / msp432r-core

MSP432 EMT core for the production silicon (RED LaunchPad only)
2 stars 5 forks source link

Spi modes 0/1 and 2/3 definitions incorrect (5.25.0) #34

Closed JRDavisUF closed 5 years ago

JRDavisUF commented 5 years ago

It looks like the definitions for SPI_MODE0 and 1 (and the definitions for SPI_MODE2 and 3) have been swapped when going from 5.23.1 to 5.25.0. My perusal of the TI documentation seems to indicate that the 5.23.1 versions were correct.

5.23.1\cores\msp432r\ti\runtime\wiring\SPI.h

define SPI_MODE0 SPI_POL0_PHA0

define SPI_MODE1 SPI_POL0_PHA1

define SPI_MODE2 SPI_POL1_PHA0

define SPI_MODE3 SPI_POL1_PHA1

5.25.0\cores\msp432r\ti\runtime\wiring\SPI.h

define SPI_MODE0 SPI_POL0_PHA1

define SPI_MODE1 SPI_POL0_PHA0

define SPI_MODE2 SPI_POL1_PHA1

define SPI_MODE3 SPI_POL1_PHA0

robertinant commented 5 years ago

Fixed in 5.25.1 and is available through the board manager.

rei-vilo commented 5 years ago

And PR #36.