Fix: disconnect after onboarding + better stability

n-vr commented 1 year ago

The phone now correctly disconnects and the devices buzzes and returns from the onboarding page without issues.

Not performing presence detection and its onboarding at the same time greatly increases stability and reduces crashes.

henriterhofte commented 1 year ago

This introduced new problems:

after a first phone is onboarded succesfully, I get thises messages, which seem encuorageing:

D (210133) Presence detection: Disabling Bluetooth discoverable
D (210133) Presence detection: Disabling A2DP
D (210133) Presence detection: Disabling Bluetooth
D (328473) Timer: Timer "ExitControlPanel" timed out

howevernext time, this causes the following: (763523) Presence detection: Waiting in WaitIfBluetoothActive which ultimately causes: D (763543) Upload task: Waiting for the other tasks to finish. and this never finishes.

henriterhofte commented 1 year ago

Another error suggests that Bluetooth is NOT properly closed after a succeful pai, i.e. if you try to add a send one immediately after the first one (which seems to go ok), you get specific error messages (see the bottom of this log)

D (12733) Buttons: Short press was detected for button "Press". Invoking callback.
D (12733) Timer: Timer "ExitControlPanel" was (re)started
D (12743) spi_master: device5 locked the bus
D (13083) spi_master: device5 release bus
D (13083) spi_master: device5 locked the bus
D (13413) spi_master: device5 release bus
D (13413) spi_master: device5 locked the bus
D (13413) spi_master: device5 release bus
D (13413) spi_master: device5 locked the bus
D (13733) spi_master: device5 release bus
D (13733) spi_master: device5 locked the bus
D (13743) spi_master: device5 release bus
D (13743) spi_master: device5 locked the bus
D (14053) spi_master: device5 release bus
D (14063) spi_master: device5 locked the bus
D (14063) spi_master: device5 release bus
D (14063) spi_master: device5 locked the bus
D (14373) spi_master: device5 release bus
D (14383) spi_master: device5 locked the bus
D (14383) spi_master: device5 release bus
D (14383) spi_master: device5 locked the bus
D (14693) spi_master: device5 release bus
D (14703) spi_master: device5 locked the bus
D (14703) spi_master: device5 release bus
D (14703) spi_master: device5 locked the bus
D (15023) spi_master: device5 release bus
D (15033) Presence detection: Enabling Bluetooth
I (15033) BTDM_INIT: BT controller compile version [3723d5b]
D (15033) BTDM_INIT: .data initialise [0x3ffae6e0] <== [0x4000d890]
D (15043) BTDM_INIT: .bss initialise [0x3ffb0000] - [0x3ffb09a8]
D (15043) BTDM_INIT: .bss initialise [0x3ffb09a8] - [0x3ffb1ddc]
D (15053) BTDM_INIT: .bss initialise [0x3ffb1ddc] - [0x3ffb2730]
D (15053) BTDM_INIT: .bss initialise [0x3ffb2730] - [0x3ffb6388]
D (15063) BTDM_INIT: .bss initialise [0x3ffb8000] - [0x3ffb9a20]
D (15073) BTDM_INIT: .bss initialise [0x3ffbdb28] - [0x3ffbdb5c]
D (15073) phy_init: loading PHY init data from application binary
D (15083) nvs: nvs_open_from_partition phy 0
D (15083) nvs: nvs_get cal_version 4
D (15093) nvs: nvs_get_str_or_blob cal_mac
D (15093) efuse: coding scheme 0
D (15093) efuse: In EFUSE_BLK0__DATA2_REG is used 8 bits starting with 8 bit
D (15103) efuse: coding scheme 0
D (15103) efuse: In EFUSE_BLK0__DATA2_REG is used 8 bits starting with 0 bit
D (15113) efuse: coding scheme 0
D (15113) efuse: In EFUSE_BLK0__DATA1_REG is used 8 bits starting with 24 bit
D (15123) efuse: coding scheme 0
D (15123) efuse: In EFUSE_BLK0__DATA1_REG is used 8 bits starting with 16 bit
D (15133) efuse: coding scheme 0
D (15143) efuse: In EFUSE_BLK0__DATA1_REG is used 8 bits starting with 8 bit
D (15143) efuse: coding scheme 0
D (15153) efuse: In EFUSE_BLK0__DATA1_REG is used 8 bits starting with 0 bit
D (15153) efuse: coding scheme 0
D (15163) efuse: In EFUSE_BLK0__DATA2_REG is used 8 bits starting with 16 bit
D (15163) nvs: nvs_get_str_or_blob cal_data
D (15173) nvs: nvs_close 9
D (15183) efuse: coding scheme 0
D (15183) efuse: In EFUSE_BLK0__DATA2_REG is used 8 bits starting with 8 bit
D (15183) efuse: coding scheme 0
D (15183) efuse: In EFUSE_BLK0__DATA2_REG is used 8 bits starting with 0 bit
D (15193) efuse: coding scheme 0
D (15193) efuse: In EFUSE_BLK0__DATA1_REG is used 8 bits starting with 24 bit
D (15203) efuse: coding scheme 0
D (15203) efuse: In EFUSE_BLK0__DATA1_REG is used 8 bits starting with 16 bit
D (15213) efuse: coding scheme 0
D (15223) efuse: In EFUSE_BLK0__DATA1_REG is used 8 bits starting with 8 bit
D (15223) efuse: coding scheme 0
D (15233) efuse: In EFUSE_BLK0__DATA1_REG is used 8 bits starting with 0 bit
D (15233) efuse: coding scheme 0
D (15243) efuse: In EFUSE_BLK0__DATA2_REG is used 8 bits starting with 16 bit
D (15733) nvs: nvs_open_from_partition bt_config.conf 1
D (15743) nvs: nvs_get_str_or_blob bt_cfg_key0
D (15743) nvs: nvs_get_str_or_blob bt_cfg_key0
D (15743) nvs: nvs_close 10
D (15743) nvs: nvs_open_from_partition bt_config.conf 1
D (15753) nvs: nvs_set_blob bt_cfg_key0 216
D (15753) nvs: nvs_close 11
D (15863) Presence detection: Enabling A2DP
D (15863) Presence detection: Enabling Bluetooth discoverable
W (15873) BT_BTC: A2DP Enable without AVRC
D (23093) nvs: nvs_open_from_partition bt_config.conf 1
D (23093) nvs: nvs_set_blob bt_cfg_key0 326
D (23103) nvs: nvs_close 12
I (23103) MAC Address: Paired with MAC address: <KNIP>
I (23103) MAC Address: Paired with Bluetooth name: S10 van Henri
D (23103) nvs: nvs_open_from_partition twomes_storage 0
D (23113) nvs: nvs_get_str_or_blob bt_names
D (23113) nvs: nvs_open_from_partition twomes_storage 0
D (23123) nvs: nvs_get_str_or_blob mac_addresses
D (23123) nvs: nvs_open_from_partition twomes_storage 1
D (23133) nvs: nvs_set_str mac_addresses <KNIP>
D (23143) nvs: nvs_close 15
D (23143) nvs: nvs_open_from_partition twomes_storage 1
D (23143) nvs: nvs_set_str bt_names S10 van Henri
D (23153) nvs: nvs_close 16
W (23393) BT_APPL: new conn_srvc id:19, app_id:0
W (23403) BT_BTC: AVRC not Init, not using it.
D (23543) nvs: nvs_open_from_partition bt_config.conf 1
D (23543) nvs: nvs_set_blob bt_cfg_key0 216
D (23553) nvs: nvs_close 17
D (23753) Timer: Timer "ExitControlPanel" was (re)started
D (23753) nvs: nvs_open_from_partition twomes_storage 0
D (23753) nvs: nvs_get_str_or_blob bt_names
D (23753) nvs: nvs_get_str_or_blob bt_names
D (23753) spi_master: device5 locked the bus
D (24103) spi_master: device5 release bus
D (24103) spi_master: device5 locked the bus
D (24433) spi_master: device5 release bus
D (24433) spi_master: device5 locked the bus
D (24433) spi_master: device5 release bus
D (24433) spi_master: device5 locked the bus
D (24763) spi_master: device5 release bus
D (24763) spi_master: device5 locked the bus
D (24763) spi_master: device5 release bus
D (24763) spi_master: device5 locked the bus
D (25083) spi_master: device5 release bus
D (25083) spi_master: device5 locked the bus
D (25083) spi_master: device5 release bus
D (25083) spi_master: device5 locked the bus
D (25413) spi_master: device5 release bus
D (25413) Presence detection: Disabling Bluetooth discoverable
D (25413) Presence detection: Disabling A2DP
D (25413) Presence detection: Disabling Bluetooth
D (30413) Buttons: Short press was detected for button "Press". Invoking callback.
D (30423) Timer: Timer "ExitControlPanel" was (re)started
D (30423) spi_master: device5 locked the bus
D (30763) spi_master: device5 release bus
D (30763) spi_master: device5 locked the bus
D (31093) spi_master: device5 release bus
D (31093) spi_master: device5 locked the bus
D (31093) spi_master: device5 release bus
D (31093) spi_master: device5 locked the bus
D (31413) spi_master: device5 release bus
D (31413) spi_master: device5 locked the bus
D (31423) spi_master: device5 release bus
D (31423) spi_master: device5 locked the bus
D (31733) spi_master: device5 release bus
D (31733) spi_master: device5 locked the bus
D (31743) spi_master: device5 release bus
D (31743) spi_master: device5 locked the bus
D (32053) spi_master: device5 release bus
D (32063) spi_master: device5 locked the bus
D (32063) spi_master: device5 release bus
D (32063) spi_master: device5 locked the bus
D (32373) spi_master: device5 release bus
D (32383) spi_master: device5 locked the bus
D (32383) spi_master: device5 release bus
D (32383) spi_master: device5 locked the bus
D (32693) spi_master: device5 release bus
D (32703) Presence detection: Enabling Bluetooth
E (32703) Presence detection: An error occured when initializing BT controller: ESP_ERR_INVALID_STATE
E (32703) Presence detection: An error occured when initializing Bluetooth with UseBluetooth: ESP_ERR_INVALID_STATE

henriterhofte commented 1 year ago

works; let's merge

energietransitie / needforheat-generic-firmware

Fix: disconnect after onboarding + better stability #84