energy-data / energydata.info

energydata.info - open data and analytics for a sustainable energy future
http://energydata.info
MIT License
25 stars 6 forks source link

Carry out final review and inspection for portal before launch #335

Closed deirdrelee closed 4 years ago

deirdrelee commented 4 years ago

So we can go live immediately once we get green light from WB final testing and validation

jodiegardiner commented 4 years ago

Hi,

Please record feedback/issues with the final test phase here. I was not able to replicate any of the issues encountered in the email.

I did address the changes requested, including moving the search box, altering font size in the search box and reordering navigation tabs so About comes first.

Thanks,

Please include links to affected pages and a screenshot of the issue if relevant.

Once you are 100% satisfied with the site, we can go live.

hy347mc commented 4 years ago

Hi,

Please record feedback/issues with the final test phase here. I was not able to replicate any of the issues encountered in the email.

I did address the changes requested, including moving the search box, altering font size in the search box and reordering navigation tabs so About comes first.

Thanks,

Please include links to affected pages and a screenshot of the issue if relevant.

Once you are 100% satisfied with the site, we can go live.

There are two issues with the logic of the filter on the Dataset page:

However, when adding on the options across different filters, the server should follow those filters and options strictly, and display only the datasets that satisfy all options across different filters. In this case, the current website works correctly.

Screen Shot 2020-02-04 at 12 48 30 PM Screen Shot 2020-02-04 at 12 48 59 PM
jodiegardiner commented 4 years ago

Hi @hy347mc ,

Just wanted to give you an update on the work I've done from your feedback above and make sure we're looking at the same build. I'll also make comments where appropriate as points we can discuss further on the call.

Site looks great on all mobile devices. The map is a bit too large (or becomes too tiny) when included on a smartphone screen in portrait mode but if you rotate the device, that's enough space for the map to fit. I could not find any device where the dataset page looked messy like you found.

The category icons looked a little cluttered on the smartphone portrait screen, so those are hidden at anything below a tablet. We could have a panel dedicated to them the same as we do for the app and the carousel.

Partners page looks great now with aligned columns.

It greatly depends which size of screen you are viewing the site on as to whether you see the arrow pointing to the map. It's tricky to fit what we have above the line in as it is. Narrowing it further would be tricky.

For the filtering issue, that will require a bit more effort to resolve so could we perhaps consider this as a post-launch priority instead?

hy347mc commented 4 years ago

Hi @hy347mc ,

Just wanted to give you an update on the work I've done from your feedback above and make sure we're looking at the same build. I'll also make comments where appropriate as points we can discuss further on the call.

Site looks great on all mobile devices. The map is a bit too large (or becomes too tiny) when included on a smartphone screen in portrait mode but if you rotate the device, that's enough space for the map to fit. I could not find any device where the dataset page looked messy like you found.

The category icons looked a little cluttered on the smartphone portrait screen, so those are hidden at anything below a tablet. We could have a panel dedicated to them the same as we do for the app and the carousel.

Partners page looks great now with aligned columns.

It greatly depends which size of screen you are viewing the site on as to whether you see the arrow pointing to the map. It's tricky to fit what we have above the line in as it is. Narrowing it further would be tricky.

For the filtering issue, that will require a bit more effort to resolve so could we perhaps consider this as a post-launch priority instead?

Great, let's get back to the filter part after launching it next Monday, Feb 10th; otherwise, looks good w/ me! Thanks Jodie.

jodiegardiner commented 4 years ago

These issues are addressed with the exception of the post launch filtering piece. Creating a new issue for that now.