fix(all): replaced sha256

energywebfoundation / ewc-system-contracts

Infrastructure contracts for EnergyWeb Chain (EWC) live launch

https://energyweb.org/

GNU General Public License v3.0

24 stars 13 forks source link

fix(all): replaced sha256 #64

Closed hai-ko closed 5 years ago

hai-ko commented 5 years ago

closes #50

danzipie commented 5 years ago

Moreover, if getDockerSha is returning the hash value of the docker, why are we hashing again here? sha256(bytes(nodeControlDb.getDockerSha(_targetValidator)))

hai-ko commented 5 years ago

@danzipie I also see no reason why we need to hash the sha again. I'll ask Jonas if there is a reason for this.

ngyam commented 5 years ago

other than that, it's LGTM

ngyam commented 5 years ago

@hai-ko please update this PR if it still can be optimized