search

energywebfoundation / ewc-system-contracts

Infrastructure contracts for EnergyWeb Chain (EWC) live launch
https://energyweb.org/
GNU General Public License v3.0
24 stars 13 forks source link

53 - additional require statements for updateValidator #67

Closed jbentke closed 5 years ago

jbentke commented 5 years ago

check for 0 values

danzipie commented 5 years ago

It would make even more sense to check that the _dockerSha length and chanspecSha length are exactly 32 bytes, not just positive

ngyam commented 5 years ago

It would make even more sense to check that the _dockerSha length and chanspecSha length are exactly 32 bytes, not just positive

bytes are arbitrary length arrays, so they do not have guaranteed lengths. It is fine

ngyam commented 5 years ago

Closes #53