feat(verifyVC): add verifyVC method to Claims Service

energywebfoundation / iam-client-lib

TypeScript library to be used within decentralised applications for authentication and authorisation using DIDs (Decentralised Identifiers) and VCs (Verifiable Credentials)

GNU General Public License v3.0

19 stars 9 forks source link

feat(verifyVC): add verifyVC method to Claims Service #592

Closed whitneypurdum closed 2 years ago

whitneypurdum commented 2 years ago

Description

Moves verifyVc and verifyIssuer to Claims Service (as was in original ICL-210, no additional changes)

Contributor checklist

[x] Breaking changes - check for any existing interfaces changes that are not backward compatible, removed method etc.
[x] Documentation - document your code, add comments for method, remember to check if auto generated docs were updated.
[x] Tests - add new or updated existed test for changes you made.
[x] Migration guide - add migration guide for every breaking change.
[x] Configuration correctness - check that any configuration changes are correct ex. default URLs, chain ids, smart contract verification on Volta explorer or EWC explorer.

whitneypurdum commented 2 years ago

It looks like it's coming along, thanks @whitneypurdum . I think the biggest thing to do is to update the @energyweb/vc-verification package to use the latest library API.

Also, it seems like the changes to domains.service and verifiable-credentials-base.service are just styling. IMO, I would remove these changes from the PR to avoid having them included in the history and limit the PR to the relevant functional changes.

It looks like it's coming along, thanks @whitneypurdum . I think the biggest thing to do is to update the @energyweb/vc-verification package to use the latest library API.

Also, it seems like the changes to domains.service and verifiable-credentials-base.service are just styling. IMO, I would remove these changes from the PR to avoid having them included in the history and limit the PR to the relevant functional changes.

Sure thing, these have been removed from PR.

whitneypurdum commented 2 years ago

@JGiter @jrhender Hopefully my changes align with what you intended above! I removed the error handling from verifyIssuer because I think the method in ew-credentials throws descriptive errors already, plus it does not return boolean value anymore for conditional check. I have squashed my commits.

CLAassistant commented 2 years ago

All committers have signed the CLA.

ewf-devops commented 2 years ago

:tada: This PR is included in version 6.0.0-alpha.29 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

ewf-devops commented 2 years ago

:tada: This PR is included in version 6.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: