Closed whitneypurdum closed 2 years ago
whitneypurdum
commented
2 years ago Looking at how tests are written, I don't think that this needs an additional test as we were already making the vp call and we are not checking the keys of the publicClaim, but I could be wrong about this...
jrhender
commented
2 years ago @whitneypurdum
Looking at how tests are written, I don't think that this needs an additional test as we were already making the vp call and we are not checking the keys of the publicClaim,
Would it be possible to test that the output EIP191JWT has the credentialStatus property?
whitneypurdum
commented
2 years ago @whitneypurdum
Looking at how tests are written, I don't think that this needs an additional test as we were already making the vp call and we are not checking the keys of the publicClaim,
Would it be possible to test that the output EIP191JWT has the
credentialStatusproperty?
Asked question about this here: https://energywebfoundation.slack.com/archives/C028ZC4G2RE/p1658240047513979. I think we will either need to append credentialStatus to claim data, or have ew-did-registry also tokenize the credentialStatus, not just the claimData.
ewf-devops
commented
2 years ago :tada: This PR is included in version 6.0.0-alpha.40 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
ewf-devops
commented
2 years ago :tada: This PR is included in version 6.0.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Description
add credentialStatus to publicClaim
if the credentialStatusOverride value is passed in, prefer it to the vp's credentialStatus
Contributor checklist
[x] Breaking changes - check for any existing interfaces changes that are not backward compatible, removed method etc.
[x] Documentation - document your code, add comments for method, remember to check if auto generated docs were updated.
[x] Tests - add new or updated existed test for changes you made.
[x] Migration guide - add migration guide for every breaking change.
[x] Configuration correctness - check that any configuration changes are correct ex. default URLs, chain ids, smart contract verification on Volta explorer or EWC explorer.