Closed JGiter closed 1 year ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: JGiter
:x: renovate[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.
This PR looks like a good start but
lib.esm
andlib
should be added to.gitignore
I believe
Yes, build artifacts are happened in root by mistake. I'll output build to dist. And no changes will be needed in .gitignore, because dist
already ignored
This build tested with Switchboard and no issues were found. The only required change is to replace internal imports like here with iam-client-lib/dist/lib.esm/src/modules/signer/signer.types
The only required change is to replace internal imports like here with iam-client-lib/dist/lib.esm/src/modules/signer/signer.types
Do you think this means that we would need to mark this as a breaking change? On one hand, it is breaking because updating the new version would require code changes and on the other, the code changes would be references to internal file locations which I would say we are free to change.
In the PR description, you wrote:
esm and cjs builds are put in different folders lib and lib.esm, which is common practice
Do you have any documentation/evidence for this being a common or best practice?
Something happend to GH. git status
says that local is up-to-date with remote, while local is ahead of several commits. Will close and reopen this PR
Something happend to GH. git status
says that local is up-to-date with remote, while local is ahead of several commits. Will close and reopen this PR
Description
Currently used
bili
build tool is poorly maintained. I suppose this is the reason of failing to update dependencies. This PR replacesbili
withrollup
. In addition of better tool it also provides simpler configurationesm
andcjs
builds are put in different folderslib
andlib.esm
, which is common practiceContributor checklist