ewf-devops
commented
4 years ago Original comment by John Henderson (Bitbucket: [John Henderson](https://bitbucket.org/John Henderson), GitHub: jrhender).
Hi @{5c0e56819aeccc769f3342d4} , I’m thinking of working on this. A couple questions when you have a moment:
- Have we implemented pagination elsewhere in the ocn-node? I took a look around but I didn’t see existing implementations
- I’m thinking that best way to implement pagination for HubClientInfo GET is to persist the HubClientInfo objects as database entities. I think this should be easy to do as we have the HubClientInfo mutation triggers centralized in the HubClientInfoListener. Then, once we have the HubClientInfo objects as a new database entity, it should be straightforward to implement the paginated queries using the Spring Data pagination apis. A downside to this is perhaps that we might have some data fragmentation/duplication, but I think actually this might let us remove the “status” and “lastUpdated” fields from PlatformEntity and therefore clarify the PlatformEntity/NetworkClientInfoEntity models.
Let me know if you have any thoughts!
Original report by Adam Staveley (Bitbucket: [Adam Staveley](https://bitbucket.org/Adam Staveley), GitHub: adamstaveley).
The sender GET request must properly implement pagination. Currently it ignores requests to paginate and considers the response the final page. This is especially needed as the network scales.