Deleted parties are communicated having a "planned" status - Githubissues

energywebfoundation / ocn-node

Apache License 2.0

5 stars 4 forks source link

Deleted parties are communicated having a "planned" status #22

Closed ewf-devops closed 3 years ago

ewf-devops commented 3 years ago

Original report by John Henderson (Bitbucket: [John Henderson](https://bitbucket.org/John Henderson), GitHub: jrhender).

Which branch contains the bug?

Develop

What is the current behaviour?

Parties which were registered with the ocn-registry and then deleted are communicated via the PlannedPartySearch as “planned”

What is the expected behaviour?

A deleted party should not be communicated as being “planned”

Unit test and suggested solution

See https://bitbucket.org/shareandcharge/ocn-node/commits/bb224c3eeba92605321697319dbddc859eefebf4?at=bug/party-search-query

My suggestion is that a guard clause be added to filter out null nodeOperator values

‌

ewf-devops commented 3 years ago

Original comment by John Henderson (Bitbucket: [John Henderson](https://bitbucket.org/John Henderson), GitHub: jrhender).

Resolved by PR #47