fix: fixing login strategy crashing and adding infura credentials

energywebfoundation / passport-did-auth

Node.js Passport authentication and authorisation strategy using DIDs(Decentralised Identifiers) and VCs(Verifiable Credentials)

GNU General Public License v3.0

15 stars 10 forks source link

fix: fixing login strategy crashing and adding infura credentials #318

Closed artursudnik closed 2 years ago

artursudnik commented 2 years ago

This PR:

fixes an issue when an entire process crashes when SSI Hub /DID/{did} endpoint responds with 500 Interal Server Error code
adds credentials to the ipfs requests

CLAassistant commented 2 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

:white_check_mark: JGiter
:white_check_mark: Passerino
:white_check_mark: artursudnik
:x: semantic-release-bot
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

artursudnik commented 2 years ago

Oh, I was wondering why npm ci works on my local copy and not on GHA.

artursudnik commented 2 years ago

GHA also fails after syncing versions between package.json and package-lock.json. I am trying to understand what is going on before merging.

artursudnik commented 2 years ago

Looks like GHA for this PR was executed with nodejs v18 for some reason and this is why it crashed when executing npm ci. It is fixed now.

ewf-devops commented 2 years ago

:tada: This PR is included in version 2.0.0-alpha.9 :tada:

The release is available on:

Your semantic-release bot :package::rocket: