energywebfoundation / passport-did-auth

Node.js Passport authentication and authorisation strategy using DIDs(Decentralised Identifiers) and VCs(Verifiable Credentials)
GNU General Public License v3.0
15 stars 10 forks source link

fix: add chainName to LoginStrategyOptions and set on cache client co… #370

Closed whitneypurdum closed 1 year ago

whitneypurdum commented 1 year ago
jrhender commented 1 year ago

@nichonien how hard would it be to add a test for this case?

jrhender commented 1 year ago

@nichonien I think a test would involve adjusting the SIWE payload to have the EWC chain ID https://github.com/energywebfoundation/passport-did-auth/blob/develop/test/LoginStrategy.siwetoken.test.ts#LL40C14-L40

nichonien commented 1 year ago

@nichonien I think a test would involve adjusting the SIWE payload to have the EWC chain ID https://github.com/energywebfoundation/passport-did-auth/blob/develop/test/LoginStrategy.siwetoken.test.ts#LL40C14-L40

Yes, I am trying to obtain a siwe signature with the message in order to add it to tests.

nichonien commented 1 year ago

@nichonien perhaps we can merge this as is and then add a test in a separate PR? How does that sound?

Yeah, sounds good. We can merge this PR now and I'll create another PR with tests once I get the required sample payload with ewc chainID

ewf-devops commented 1 year ago

:tada: This PR is included in version 2.0.0-alpha.30 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

ewf-devops commented 1 year ago

:tada: This PR is included in version 2.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: