eneshecan / whatsapp-for-linux

An unofficial WhatsApp desktop application for Linux.
GNU General Public License v3.0
996 stars 101 forks source link

webkit_web_view_run_javascript deprecation #291

Open jesperpedersen opened 1 year ago

jesperpedersen commented 1 year ago

I'm getting

whatsapp-for-linux/src/ui/WebView.cpp: In member function ‘void wfl::ui::WebView::sendRequest(std::string)’:
whatsapp-for-linux/src/ui/WebView.cpp:244:43: warning: ‘void webkit_web_view_run_javascript(WebKitWebView*, const gchar*, GCancellable*, GAsyncReadyCallback, gpointer)’ is deprecated: Use 'webkit_web_view_evaluate_javascript' instead [-Wdeprecated-declarations]
  244 |             webkit_web_view_run_javascript(*this, script.c_str(), nullptr, nullptr, nullptr);
      |             ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/webkitgtk-4.0/webkit/WebKitPrintOperation.h:29,
                 from webkitgtk-4.0/webkit2/webkit2.h:72,
                 from whatsapp-for-linux/src/ui/WebView.hpp:4,
                 from whatsapp-for-linux/src/ui/WebView.cpp:1:
/usr/include/webkitgtk-4.0/webkit/WebKitWebView.h:526:1: note: declared here
  526 | webkit_web_view_run_javascript                       (WebKitWebView             *web_view,
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

on master using Fedora 37 with gcc 12.2 w/ webkit2gtk4.0-2.40.1-1.fc37.x86_64

eneshecan commented 1 year ago

Yeah, I kept this for now to not break backward compatibility.

jesperpedersen commented 1 year ago

:+1: