search

enesozturk / react-native-hold-menu

📱 A performant, easy to use hold to open context menu for React Native powered by Reanimated 🚀
https://enesozturk.github.io/react-native-hold-menu/
MIT License
1.38k stars 90 forks source link

Expo 49 - Breaking Changes #111

Open hazirmagron opened 1 year ago

hazirmagron commented 1 year ago

Describe the bug The overlay is completely broken since I updated to Expo@49.

The 'HoldItem' child components still animate when pressed. The overlay and menu never show up, however, and the child component that was pressed is frozen on the screen.

Package versions

holma91 commented 11 months ago

Is this fixed yet?

pavelbabenko commented 11 months ago

Same issue

raymond-tetteh commented 10 months ago

I have the same issue.

mimo-10 commented 10 months ago

got the same issue her, any solutions suggested?

Nasseratic commented 10 months ago

Hello guys 👋🏼

I am working on a fix here 🤓 https://github.com/enesozturk/react-native-hold-menu/pull/112

It's WIP, but I got everything working on my project

moedeveloper commented 10 months ago

Unfortunately same issue :(

devmalcolm commented 9 months ago

Hey, is there a fixed version ? I saw the new PR being WIP and changes seems to works perfecly. Did you already publish it ? Or still WIP ? Thanks ✌️

Nasseratic commented 9 months ago

Hey @devmalcolm

Yeah, it should be ready. But I can't publish it as I am not a contributor. Will try to bring someone to approve my PR. For now feel free to install the version in the PR by:

npm i https://github.com/Nasseratic/react-native-hold-menu-upgrade-expo-49.git#expo-49-needed-fixes
viktor32 commented 7 months ago

@Nasseratic great job, thank you!

But I think the correct command to install from your repo is (with the branch where the fix)

npm i https://github.com/Nasseratic/react-native-hold-menu-upgrade-expo-49.git#expo-49-needed-fixes
BennoCrafter commented 4 months ago

Hey @Nasseratic! I've downloaded your updated version, but sadly it still doesnt work. Is it just me, or is it because there is a new version?

MathiasSvDK commented 3 months ago

Same issue. Using expo 50

mimo-10 commented 3 months ago

It works, you only need to use this version npm i https://github.com/Nasseratic/react-native-hold-menu-upgrade-expo-49.git#expo-49-needed-fixes And you need to make a change inside the backdrop component in order to make it work on android. Just change View, to AnimatedBlurView

BennoCrafter commented 3 months ago

Just for android?

mimo-10 commented 3 months ago

Yes, you need to do that only for android, for ios it works without any changes.

tconroy commented 1 month ago

Im having trouble trying to install this fork.. 🤔 any ideas?

❯ npm i https://github.com/Nasseratic/react-native-hold-menu-upgrade-expo-49.git#expo-49-needed-fixes
zsh: no matches found: https://github.com/Nasseratic/react-native-hold-menu-upgrade-expo-49.git#expo-49-needed-fixes
Nasseratic commented 1 month ago

@tconroy It works for me 😅

tconroy commented 1 month ago

@tconroy It works for me 😅

Yes I just needed to wrap the url as a string and now it works 😊

daxaxelrod commented 1 week ago

Can we merge the upgrade to 49 (also confirming nasseratic's fix works on expo 50) to main