search

enesozturk / react-native-hold-menu

📱 A performant, easy to use hold to open context menu for React Native powered by Reanimated 🚀
https://enesozturk.github.io/react-native-hold-menu/
MIT License
1.4k stars 91 forks source link

Padding Bug #93

Open Beyazatli opened 1 year ago

Beyazatli commented 1 year ago

Describe the bug Hello, There is a problem with the bottom item in the appearance of the drop-down menu.

Here are some devices where I encountered the view (space) error: iPhone 11 Samsung (SM-A307FN/DS) Samsung (SM-A920F)

I tried styling it but it had no effect.

To Reproduce Steps to reproduce the behavior:

  1. Open hold menu.

Expected behavior Just a little bit padding for last (actually bottom) item.

Screenshots (Two different devices)

Package versions

Additional context "Actions" section icon does not load (any icon - 'home', 'archive', etc.).

Beyazatli commented 1 year ago

image

hi, when I updated the 37. line of the "style.ts" file from the node_modules folder, problem was solved. (temporarily 👾)

paddingVertical: styleGuide.spacing * 1.25, to paddingVertical: styleGuide.spacing * 1.1,

Beyazatli commented 1 year ago

Hi, previous solution doesnt work when i tested it on 10 different devices. rather than entering a different size for each screen format, the style.ts file needs to be rewritten with fixed dimensions.

enesozturk commented 1 year ago

Hey there, I saw the PR about the fix. I guess giving the flex is not a good solution since the sizes of the menu are really really important for the animations to run perfectly. We cannot let the menu calculate the size automatically.

So for the problem, this is not expected for sure, didn't see it before.