Documentation issue causes "TypeError: vCard is not a function"

enesser / vCards-js

Create vCards to import contacts into Outlook, iOS, Mac OS, and Android devices from your website or application.

MIT License

419 stars 155 forks source link

Documentation issue causes "TypeError: vCard is not a function" #33

Closed mbain closed 5 years ago

mbain commented 5 years ago

The example code in the documentation on the npm page causes an error in Node 8. The line: vCard = vCard() causes: TypeError: vCard is not a function. Changing it to something like userVCard = vCard() fixes the issue.

enesser commented 5 years ago

Really? Haven't gotten this in Node 8, and Travis CI tests pass. Are you using TypeScript or any other special settings?

Thanks!

enesser commented 5 years ago

Although Travis tests use a different variable, let me check on that.

Thanks.

mbain commented 5 years ago

No TypeScript. Just Node.js 8.14.0 running on Firebase.

enesser commented 5 years ago

Addressed in v2.10.0. Thanks!