search

enesser / vCards-js

Create vCards to import contacts into Outlook, iOS, Mac OS, and Android devices from your website or application.
MIT License
426 stars 156 forks source link

is necessary use colon instead of semicolon in order to set the social networks correctly #50

Closed yasmanets closed 1 year ago

yasmanets commented 4 years ago

I have fixed the build of X-SOCIALPROFILE, using the semicolon the text CHARSET-UTF8 appears in the social network property of the contact, so putting colon instead of the semicolon can solve this problem

DominicSherman commented 3 years ago

@enesser I believe this PR would fix an issue we are running into as well. Could we get this merged and a new release out there?

kennethbrent commented 3 years ago

@enesser Having this problem as well. Social links do not work and appear as @charset=utf-8 on IOS.

It looks like vCardFormatter.js has been updated since @yasmanets commit because my file is slightly different, with an encodingPrefix in my version. if (vCard.socialUrls) { for (var key in vCard.socialUrls) { if (vCard.socialUrls.hasOwnProperty(key) && vCard.socialUrls[key]) { formattedVCardString += 'X-SOCIALPROFILE' + encodingPrefix + ';TYPE=' + key + ':' + e(vCard.socialUrls[key]) + nl(); } } }

tomasikp commented 2 years ago

👍