search

enfuse / asae-backstage-plugin

Backstage plugin
4 stars 1 forks source link

Avoid direct react-router dependency #9

Closed Rugvip closed 1 year ago

Rugvip commented 1 year ago

This plugin has a direct dependency on react-router-dom. This make it more likely that installations of this plugin lead to duplicate instances of react-router, which causes issues like the one seen in #1. I recommend moving it over to peerDependencies. If you do support React Router beta (which you probably do) then you could make the range "6.0.0-beta.0 || ^6.3.0" as well.

Rugvip commented 1 year ago

Fixed in https://github.com/enfuse/asae-backstage-plugin/commit/54dc806a6250706276867bf56d3ab33c333b246f