search

engageLively / galyleo-dashboard

3 stars 2 forks source link

Need to refactor PublishedDashboard and Dashboard #118

Closed rickmcgeer closed 1 year ago

rickmcgeer commented 1 year ago

There's a huge code overlap, which should be consolidated in a single object. Essentially, Dashboard is just PublishedDashboard + a UI, and we should refactor that way

rickmcgeer commented 1 year ago

There is now a new branch, factored-dashboard, which contains the factoring. A new file, studio/dashboard-common.cp.js has the DashboardCommon object, and now PublishedDashboard and Dashboard extend DashboardCommon The factored form still needs to be tested and reviewed.

rickmcgeer commented 1 year ago

factored-dashboard has now been reviewed and merged into main (commit 44163eae92f986d478886d4c80a1ba2392b066c4).

Done.