search

engageLively / galyleo-dashboard

3 stars 2 forks source link

Opening GalyleoRichTextControl causes page to hang #157

Open rickmcgeer opened 1 year ago

rickmcgeer commented 1 year ago 
import { part } from "lively.morphic";
import { GalyleoRichTextControl } from "galyleo-dashboard/studio/controls/text.cp.js";

part(GalyleoRichTextControl).openInWorld() (or opening any containing morph, all the way to Galyleo) causes the world to hang. Commenting out the text controls and font color input submorphs takes care of the problem. Presumably what's happened is that RichTextControl, which we import from lively.ide/studio/controls/text.cp.js, duplicates this functionality and this is causing a loop. Tentative solution is to delete the commented out code Assigning to @merryman for comment and review

merryman commented 1 year ago

The reason is an infinite loop in the text bounds measuring that is triggered by the number input morphs. I have observed this issue already in the past and believe I have a fix for it lying around somewhere, I just havent pushed it yet.