The display is not working correctly with the filter I created.

engageLively / galyleo-dashboard

3 stars 2 forks source link

The display is not working correctly with the filter I created. #197

Open Shima-Nao opened 5 months ago

Shima-Nao commented 5 months ago

@rickmcgeer @merryman @mhemmings-engage *Please refer to the video. It seems the slider in the filter is not working properly. For example, the Year remains a fixed value.

https://github.com/engageLively/galyleo-dashboard/assets/91653807/877a75ef-2b3a-4892-98e2-49e4c8d5962d

rickmcgeer commented 4 months ago

This is a bug in the remote_tables code, which has been fixed on my development system. It will be completely revised once the SDTP/Data Plane is released, which will happen this week.

Shima-Nao commented 4 months ago

@rickmcgeer @merryman

1) The dialog cannot be closed even if the button is pressed. 2) Bug report not fixed yet.

*Other issues seem to have been fixed.

https://github.com/engageLively/galyleo-dashboard/assets/91653807/f1adfaa1-8f22-4617-b802-378d40a2c754

rickmcgeer commented 4 months ago

I have fixed this locally and I'm deploying tonight

rickmcgeer commented 4 months ago

this should now be fixed, @Shima-Nao . Please confirm

Shima-Nao commented 4 months ago

this should now be fixed, @Shima-Nao . Please confirm

@rickmcgeer I have confirmed that the view control is properly disappearing. Thank you for addressing this.

1) The dialog cannot be closed even if the button is pressed.

I have one thing to confirm. The column selection of this view control can no longer be moved to the top priority. (If I remember correctly, the X-axis was designed to be moved to the top). Currently, the selected column moves to the top after committing the selection and reopening it. Has the specification been changed?

2) Bug report not fixed yet.

The bug report still seems to be unresolved. It's not critical, so it doesn't need to be rushed, but please fix it as soon as possible.

rickmcgeer commented 4 months ago

@Shima-Nao

The columns are moved after you select order mode with the pen icon at the top right This is the icon: The boxes on the left turn into "burgers" (three bars): The pointer icon changes to a hand and the order can be changed: Let me know if this doesn't work for you

And the order is only relevant for selected columns -- unselected columns aren't relevant. The column order in the two images you showed are functionally equivalent, since the "Year" and "State" columns won't be forwarded to the chart.

Clicking the pen icon again goes back to select/deselect view

Shima-Nao commented 4 months ago

@rickmcgeer Thank you for telling. googd works it.