search

engagementlab / boston-civic-media

Site for the Boston Civic Media consortium and conference
1 stars 0 forks source link

events: images are being forced into 150x150 size and are stretching #100

Open jpailthorpe opened 7 years ago

jpailthorpe commented 7 years ago

This will be solved by removing the cloudinary width and height restriction. PMs should be advised to only upload photos that are optimized for web so they don't become a resource drain on site performance. With this fix, you won't have to worry about resizing images to fit an exact dimension, only be aware of file size.

jpailthorpe commented 7 years ago

more info on this and it is much more complex than originally thought.

@codeworthy The quickest and safest solution is to always upload a square image. You might want to just ask @aidanrae to resize/rework a photo that you will use for the event photo to make it display correctly before uploading to keystone.

@johnnycrich you can also use c_fill or c_pad instead of c_scale, which will solve the problem of the image looking stretched and weird, but will also create a situation where the image focal point is not specifically set (so you can't control, say, where the image crops).

screen shot 2017-06-13 at 2 34 16 pm screen shot 2017-06-13 at 2 34 37 pm

rebeccamichelson commented 7 years ago

@esalling23 some of these images still look stretched (https://bostoncivic.media/events), will you please fix them?

esalling23 commented 7 years ago

Sure, I will assign myself and take a look tomorrow @codeworthy

rebeccamichelson commented 7 years ago

@esalling23 I've updated the photos but please add a subtitle that images uploaded should be 600X600 so they don't appear fuzzy on the events page.

esalling23 commented 7 years ago

https://github.com/keystonejs/keystone/issues/4327 This seems to be an issue with CloudinaryImage fields - I tested this on our Engagement Lab Website as well (which is also on KeystoneJS v4) and no notes are appearing on CloudinaryImage fields.

rebeccamichelson commented 7 years ago

@esalling23 what do you recommend might be the next steps for this? Is another solution possible or should we move this to either the Icebox or Closed?