search

engagementlab / boston-civic-media

Site for the Boston Civic Media consortium and conference
1 stars 0 forks source link

Events page: Featured event makes no sense with how many events we have, making duplicate listing in upcoming events. #79

Open kanarinka opened 7 years ago

kanarinka commented 7 years ago

Is that the intended behavior? Seems like whatever is a featured event shouldn't also be in the list of upcoming events. We don't tend to have more than 1 event planned at a time, so this would be a pretty frequent situation

jpailthorpe commented 7 years ago

any event can be featured, it is an optional enabler in keystone. That said, right now the featured event code which displays a featured event as a large header on the events page is commented out, so it will never show on the events page and only on the home page when featured is enabled in keystone. If this is okay, we can move this to done. However, below is my suggestion for a new design approach to contextualize the event page. Feel free to close the issue if you feel like the page is okay as is. (or just comment and I will close)

I agree this is bad design, but it was driven by the content originally. I raised this a month ago and got pushback on it being out of scope so we didn't change the core function of the page. instead we just updated the styles to make things look cleaner.

I originally suggested we make the events page not have a featured event and instead have a more descriptive header block that describes WHAT these events are and why we do them and who goes to them, etc. Since this would contextualize to folks generally how we approach events. again got pushback that this was out of scope. see #29 for some more info on this too.

kanarinka commented 7 years ago

I don't know what Jordan's answer means - basically I do not ever want to see duplicate events on the home page or the events page. If that means taking out the featured event that is fine.

esalling23 commented 7 years ago

@kanarinka we currently arent using featured events anywhere on the website, instead we are using upcoming. Featured events on the homepage being duplicated on the events page seems like a non-issue to me and would actually make sense, as long as we don't show featured events on the events page.

esalling23 commented 7 years ago

@kanarinka since another issue already calls for changing the homepage from 'featured events' to just be 'events' with the most recent one featured, this seems to not really apply to the website any more

kanarinka commented 7 years ago

Ok great - close it out!

El El vie, jul. 21, 2017 a las 14:51, Erica Marchman Salling < notifications@github.com> escribió:

@kanarinka https://github.com/kanarinka since another issue already calls for changing the homepage from 'featured events' to just be 'events' with the most recent one featured, this seems to not really apply to the website any more

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/engagementgamelab/boston-civic-media/issues/79#issuecomment-317083358, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDS1rRymcv3fbcTPsonqrj6YClDD5nvks5sQPMlgaJpZM4NuGrj .

rebeccamichelson commented 7 years ago

@esalling23 the homepage still says "featured event" instead of "events" so please address this and add a hyperlink to "see more events"

esalling23 commented 7 years ago

@codeworthy ready for review at qa.bostoncivic.media

rebeccamichelson commented 7 years ago

@esalling23 This looks great but the "See more events" link goes to an incomplete page. Perhaps this is not an issue but just a stand-in. I'm flagging it just in case.