engagementlab / emerging-citizens

Emerging Citizens is a suite of digital multiplayer games that teaches students how to critique and create civic media.
MIT License
2 stars 0 forks source link

GLOBAL: player is sometimes kicked from a session immediately after joining #174

Open mattwbenson opened 7 years ago

mattwbenson commented 7 years ago

The iPad will join the session, but then the "network issues" dialogue will appear immediately, and the device disappears from the lobby. The error console then displays the following WebSocket connection error: screen shot 2016-10-26 at 3 00 19 pm

If the page is reloaded, the device is then able to join.

jpailthorpe commented 7 years ago

confirmed that this also happens on phone devices. What the player sees is usually a blank screen with just the background. Upon refresh, the game loads properly.

johnnycrich commented 7 years ago

I removed smartlook from prod as it looks like it caused the error responsible.

esalling23 commented 7 years ago

Moving this into backlog because could not fix. Found through testing: Game ends with socket error "Transport close" - cannot find why socket is closing Added console.log in PlayerReady, PlayerIsActive, and GameInSession functions in the Core.js script in learning-games-core Initially seemed as though the game checked if the player was active before the game started (players are set to active only after game starts) so that player was seen as 'inactive' and kicked out. After more testing, it seems that the socket may be starting this loop in the first place. Since adding these logs and doing testing, however, players are kicked out less often. Cannot seem to reproduce on QA so this may be a local issue.

jpailthorpe commented 7 years ago

Sounds like we need to test this again in the current prod build. @mattwbenson moving to review

mattwbenson commented 7 years ago

Still seeing this behavior on production, not sure if it's connected to same issue.

jpailthorpe commented 7 years ago

I think this is one of those finniky issues that might just be hard/impossible to fix. I don't want to waste anymore resources on this one unless it starts to reappear and happen a bunch in showing. therefore I am going to move it to done for future reference.