search

engaging-computing / iOS

iOS projects relating to isenseproject.org
1 stars 4 forks source link

Ra17 #59

Closed Rajia closed 9 years ago

Rajia commented 9 years ago

@stowellm Please review this pull request when you get a chance! The problems that were fixed include:

=> The Project Button's text label was saying "Uploading to Project: Not Set" despite the fact that a default project was set.

=> The Enter Project Button was not actually changing project, and

=> The Browse Project Button was causing the app to crash.

All these problems have been fixed! Also I made some minor UI changes to the color of the text labels and there is now a login button (this will be implemented once I am finished with the fields checker).

Lastly, the one line of code I sent you needs to be added to the iSENSE Api.

Let me know if you need me to make any changes to this pull request. Thanks!

stowellm commented 9 years ago

I'll review this tomorrow as well as fix up the ProjectBrowserViewController in the API so that browse won't crash in the app.

stowellm commented 9 years ago

Everything looks good! I'll pull it.

Rajia commented 9 years ago

?Awesome, Thanks!

From: Mike Stowell notifications@github.com Sent: Tuesday, December 23, 2014 7:52 AM To: isenseDev/iOS Cc: Abdelaziz, Rajia M Subject: Re: [iOS] Ra17 (#59)

Everything looks good! I'll pull it.

Reply to this email directly or view it on GitHubhttps://github.com/isenseDev/iOS/pull/59#issuecomment-67952524.