search

engaging-computing / phpSENSE

An educational data analytics platform.
http://isenseproject.org
14 stars 10 forks source link

Styling of front page frequently truncates Featured Experiment titles. #576

Closed ivanrudnicki closed 11 years ago

ivanrudnicki commented 11 years ago

I know everyone is focused on rSENSE right now, but good old iSENSE is suffering from a bug that is ugly but should be straightforward to address: because of the large font used to display featured experiment titles, the titles are frequently truncated. Looks bad. Easy to fix. Let's do it.

mmcguinn commented 11 years ago

On dev - Looks like it did not break anything with the layout.

ivanrudnicki commented 11 years ago

Hmm. On Dev, the titles wrap at the end of the line. Not so on the production site. Was there an update that didn't make it onto production?

On Wed, Jan 30, 2013 at 3:18 PM, mmcguinn notifications@github.com wrote:

On dev - Looks like it did not break anything with the layout.

— Reply to this email directly or view it on GitHubhttps://github.com/isenseDev/iSENSE/issues/576#issuecomment-12910099.

mmcguinn commented 11 years ago

It's not on the production site. Jeremy and Mike do tests on Fridays to make sure everything is ok before any production pushes are made. If you need to have it push for today for whatever reason I can do it early, but I'd prefer to let normal tests happen if it's not an issue.

-Michael

On Wed, Jan 30, 2013 at 4:32 PM, ivanrudnicki notifications@github.comwrote:

Hmm. On Dev, the titles wrap at the end of the line. Not so on the production site. Was there an update that didn't make it onto production?

On Wed, Jan 30, 2013 at 3:18 PM, mmcguinn notifications@github.com wrote:

On dev - Looks like it did not break anything with the layout.

— Reply to this email directly or view it on GitHub< https://github.com/isenseDev/iSENSE/issues/576#issuecomment-12910099>.

— Reply to this email directly or view it on GitHubhttps://github.com/isenseDev/iSENSE/issues/576#issuecomment-12913689.

ivanrudnicki commented 11 years ago

No need to take action before tomorrow. Thanks for looking into this.

On Thu, Jan 31, 2013 at 10:15 AM, mmcguinn notifications@github.com wrote:

It's not on the production site. Jeremy and Mike do tests on Fridays to make sure everything is ok before any production pushes are made. If you need to have it push for today for whatever reason I can do it early, but I'd prefer to let normal tests happen if it's not an issue.

-Michael

On Wed, Jan 30, 2013 at 4:32 PM, ivanrudnicki notifications@github.comwrote:

Hmm. On Dev, the titles wrap at the end of the line. Not so on the production site. Was there an update that didn't make it onto production?

On Wed, Jan 30, 2013 at 3:18 PM, mmcguinn notifications@github.com wrote:

On dev - Looks like it did not break anything with the layout.

— Reply to this email directly or view it on GitHub< https://github.com/isenseDev/iSENSE/issues/576#issuecomment-12910099>.

— Reply to this email directly or view it on GitHub< https://github.com/isenseDev/iSENSE/issues/576#issuecomment-12913689>.

— Reply to this email directly or view it on GitHubhttps://github.com/isenseDev/iSENSE/issues/576#issuecomment-12946867.

stowellm commented 11 years ago

Screen Shot 2013-02-01 at 11 44 56 AM

Creating a really long experiment name gets rid of the "Created by" portion. Is this part of the issue?

ivanrudnicki commented 11 years ago

I hadn't considered that possibility, but now that you point it out, it seems like we should be able to have long titles and authors? (But two-liners don't seem to be a problem, and two lines afford a lot more experiment title flexibility than just one.)

On Fri, Feb 1, 2013 at 11:46 AM, Mike Stowell notifications@github.comwrote:

[image: Screen Shot 2013-02-01 at 11 44 56 AM]https://f.cloud.github.com/assets/1039162/118932/cd95fda6-6c8e-11e2-9b58-91b30b892e0f.png

Creating a really long experiment name gets rid of the "Created by" portion. Is this part of the issue?

— Reply to this email directly or view it on GitHubhttps://github.com/isenseDev/iSENSE/issues/576#issuecomment-13002411.

mmcguinn commented 11 years ago

I've changed the limit to twice the old one (which was a safe value for 1 line) and pushed that to live. There will still be issues with very long name on the experiment page, but in general names up to 64 characters will show up in the featured list.