search

engaging-computing / phpSENSE

An educational data analytics platform.
http://isenseproject.org
14 stars 10 forks source link

Hopefully this will fix all Hassans (My) problems #590

Closed mmcguinn closed 11 years ago

mmcguinn commented 11 years ago

@hmcq6

So, from Hassan's comment elsewhere: "Just finished #582 and #583 working on #588" I assume that refers to this completely unlabeled pull request.

  1. This is broken for editing (loops a bunch of empty alert boxes when you edit and save a string).
  2. Validation just green lights everything now as far as I can tell. I guess this is an improvement over nearly random behavior but it's still not validating.

I'll try to fix 1. myself if I have time tonight, but I'm not pulling this in its current state.

fgmart-zz commented 11 years ago

May I have an update on this? Thanks.

mmcguinn commented 11 years ago

I've been working on it the past few days.

Saving in edit.php was not working at all, but I believe I've fixed that, as well as the header.

I'm working on validation now, I was hoping to have it done before leaving but I've hit several unexpected snags that will make it take a bit longer.

mmcguinn commented 11 years ago

Also fixes #585.