search

engaging-computing / phpSENSE

An educational data analytics platform.
http://isenseproject.org
14 stars 10 forks source link

Zooming out and then changing the Y axis field creates problems with the timeline #612

Closed ivanrudnicki closed 11 years ago

ivanrudnicki commented 11 years ago

Here's how to produce the problem:

1) Start here: http://isenseproject.org/highvis.php?sessions=6761+6760

2) Switch to Timeline.

3) Zoom Out one level.

4) Add Temperature to Y axis.

5) Remove pH from Y axis.

mmcguinn commented 11 years ago

This is intended behavior, and was a change that was forced to come along with the zoom change. There is no longer a lock zoom checkbox, but the zoom will "lock" if you do any form of manual zooming. Hitting reset zoom will do what I think you want.

Sorry I forgot to mention this initially.

-Michael

On Thu, Jun 6, 2013 at 10:58 AM, ivanrudnicki notifications@github.comwrote:

Here's how to produce the problem:

1) Start here: http://isenseproject.org/highvis.php?sessions=6761+6760

2) Switch to Timeline.

3) Zoom Out one level.

4) Add Temperature to Y axis.

5) Remove pH from Y axis.

— Reply to this email directly or view it on GitHubhttps://github.com/isenseDev/iSENSE/issues/612 .

ivanrudnicki commented 11 years ago

I may be missing something, but there's seems to be a deeper problem here.

Look at the temperature timeline for the two stations without zooming out. This is a relatively smooth sin wave, with temp values ranging from 0 to the upper 20s over the two year period.

Then repeat the steps in the bug report. For me (in Firefox), doing the latter yields a jagged temperature timeline, with completely different values on the y axis (the range is 0 to 12.5), and seemingly many missing data points.

On Thu, Jun 6, 2013 at 11:06 AM, mmcguinn notifications@github.com wrote:

This is intended behavior, and was a change that was forced to come along with the zoom change. There is no longer a lock zoom checkbox, but the zoom will "lock" if you do any form of manual zooming. Hitting reset zoom will do what I think you want.

Sorry I forgot to mention this initially.

-Michael

On Thu, Jun 6, 2013 at 10:58 AM, ivanrudnicki notifications@github.comwrote:

Here's how to produce the problem:

1) Start here: http://isenseproject.org/highvis.php?sessions=6761+6760

2) Switch to Timeline.

3) Zoom Out one level.

4) Add Temperature to Y axis.

5) Remove pH from Y axis.

— Reply to this email directly or view it on GitHub< https://github.com/isenseDev/iSENSE/issues/612> .

— Reply to this email directly or view it on GitHubhttps://github.com/isenseDev/iSENSE/issues/612#issuecomment-19051565 .

mmcguinn commented 11 years ago

Ok, you're right... That's very odd.

I think this is a data reduction bug, not specifically a zooming one. It might be related (or the same) as a bug I have up on rSENSE as well (which would make sense).

As a stopgap - either turn on full detail or toggle it.

On Thu, Jun 6, 2013 at 11:20 AM, ivanrudnicki notifications@github.comwrote:

I may be missing something, but there's seems to be a deeper problem here.

Look at the temperature timeline for the two stations without zooming out. This is a relatively smooth sin wave, with temp values ranging from 0 to the upper 20s over the two year period.

Then repeat the steps in the bug report. For me (in Firefox), doing the latter yields a jagged temperature timeline, with completely different values on the y axis (the range is 0 to 12.5), and seemingly many missing data points.

On Thu, Jun 6, 2013 at 11:06 AM, mmcguinn notifications@github.com wrote:

This is intended behavior, and was a change that was forced to come along with the zoom change. There is no longer a lock zoom checkbox, but the zoom will "lock" if you do any form of manual zooming. Hitting reset zoom will do what I think you want.

Sorry I forgot to mention this initially.

-Michael

On Thu, Jun 6, 2013 at 10:58 AM, ivanrudnicki notifications@github.comwrote:

Here's how to produce the problem:

1) Start here: http://isenseproject.org/highvis.php?sessions=6761+6760

2) Switch to Timeline.

3) Zoom Out one level.

4) Add Temperature to Y axis.

5) Remove pH from Y axis.

— Reply to this email directly or view it on GitHub< https://github.com/isenseDev/iSENSE/issues/612> .

— Reply to this email directly or view it on GitHub< https://github.com/isenseDev/iSENSE/issues/612#issuecomment-19051565> .

— Reply to this email directly or view it on GitHubhttps://github.com/isenseDev/iSENSE/issues/612#issuecomment-19052552 .

mmcguinn commented 11 years ago

Related to https://github.com/isenseDev/rSENSE/issues/302

mmcguinn commented 11 years ago

I've hotfixed this now. If you repeat that procedure it still looks pretty fugly (results of some optimally bad clipping, mostly), but if you zoom out or reset zoom the it looks as you would expect.

mmcguinn commented 11 years ago

Just to leave a further note: The bad clipping can probably be improved (This graph is a really good example of it failing worst case), but that's another task on its own.

mmcguinn commented 11 years ago

@ivanrudnicki Turns out the clipping issue was actually very obvious and minor upon investigation. It's been fixed.

Zooming, specifically reset zoom, still behaves a bit odd, but I think this is due to the older version of highcharts. I'd rather not attempt to update it on iSENSE unless its really necessary.