search

engaging-computing / phpSENSE

An educational data analytics platform.
http://isenseproject.org
14 stars 10 forks source link

reset zoom doesn't always work correctly #613

Closed fgmart-zz closed 11 years ago

fgmart-zz commented 11 years ago

Have a look at this data set in timeline view:

http://isenseproject.org/highvis.php?sessions=7015+7014+7013+7012+7011+7009+7010+7008+7007

now zoom in on the flat tail at the lower right.

now click "reset zoom". nothing happens (or it seems to zoom out a tiny bit).

tested both on FF on Mac and Chrome on one of the tablets -- same behavior on both.

mmcguinn commented 11 years ago

It's zooming out a tiny bit (if you hit it enough times it will go back out, but obviously it that's not a solution). I noticed this when fixing the previous zooming bug from last week, but it seems more prevalent now for some reason.

Since the zooming code is now the same between iSENSE and rSENSE, my initial thought is it's due to some difference in the highcharts version. I really don't want to introduce even more new code by updating highcharts, so I'm going to look into fixing this with a simple patch rather than that.

mmcguinn commented 11 years ago

After looking at this for a while I determined the zooming behavior between versions changed in such a way that updated was the only reasonable solution. I'm going to push it to dev momentarily.

mmcguinn commented 11 years ago

Okay it's up now.

I don't see any issues caused by at at a cursory glance, I used this dataset to test it http://isensedev.cs.uml.edu/highvis.php?sessions=6288+5590+5588+5586+5585+5584

Let me know and I'll pull it to live.

fgmart-zz commented 11 years ago

Generate Elapsed Time seems to not work on this viz... should I be worried about that?

On Mon, Jun 10, 2013 at 2:39 PM, mmcguinn notifications@github.com wrote:

Okay it's up now.

I don't see any issues caused by at at a cursory glance, I used this dataset to test it http://isensedev.cs.uml.edu/highvis.php?sessions=6288+5590+5588+5586+5585+5584

Let me know and I'll pull it to live.

— Reply to this email directly or view it on GitHubhttps://github.com/isenseDev/iSENSE/issues/613#issuecomment-19217851 .

Work Ready Life Ready World Ready

Director, Engaging Computing Group http://www.cs.uml.edu/ecg Associate Professor, Computer Science http://blog.uml.edu/cs Director of Student Success, College of Scienceshttp://blog.uml.edu/science University of Massachusetts Lowell, 1 University Avenue, Lowell MA 01854 p: 978/934–1964 f: 978/934–2705 email: fredm@cs.uml.edu

mmcguinn commented 11 years ago

What doesn't work about it? I just tried it and it works fine for me.

mmcguinn commented 11 years ago

Pulled to live. Opening a new bug for a lingering issues.