search

engaging-computing / rSENSE

A data aggregation and visualization tool for classroom science
10 stars 48 forks source link

Vis page awkward when looking at empty dataset #2718

Open fgmart-zz opened 7 years ago

fgmart-zz commented 7 years ago

Check out http://isenseproject.org/projects/2490. This is one of the projects made by middle schoolers and has a companion app in the Play Store.

There are a bunch of data sets contributed on October 8 2017 that when viewed, cause the vis page to break.

doug-salvati commented 7 years ago

These data sets are empty. Easy solution is to have a warning come up and redirect you back, much like #2680. Best solution IMO is to make sure you can't save a dataset with all empty rows.

fgmart-zz commented 7 years ago

I think "looks awkward" understates the problem; the Vis page appears as though it's not fully rendering (see below).

Perhaps the solution is to (1) have it fully render, and (2) default to the Summary screen, with a message like:

These data set(s) don't contain any data.

brokenvis

fgmart-zz commented 7 years ago

Hahhah on me -- that screencap looks better than it actually does when you first open the page. Below is the "broken" state to which I referred. When I resized the window, iSENSE made things look nicer, per above :)

selection_173

doug-salvati commented 7 years ago

Let's go roughly with what Fred said, but I think all tabs should be disabled and have messages like we do anytime a vis is disabled: image except it would say "No data sets"