search

engarde-dev / engarde

A library for defensive data analysis.
MIT License
501 stars 40 forks source link

Add exception chaining for both py2 and py3 using the six library #39

Closed alysivji closed 7 years ago

alysivji commented 7 years ago

Based on the exception chaining conversation from https://github.com/TomAugspurger/engarde/pull/34, I added code that displays the correct traceback for both py2 and py3 runtimes.

Tested in 3.6 and 2.7 and was able to see why the DataFrames were different when using the is_same_as() function.

Also changed setup.py to add six as a required install.

TomAugspurger commented 7 years ago

Thanks, I'll look more closely and merge this next week.

alysivji commented 7 years ago

Learned a bit more about packaging, so updating requirements.txt with a reference to six

TomAugspurger commented 7 years ago

Thanks @alysivji