engineer-dao / platform

The EngineerDAO dApp for interacting with job contracts
engineer-dao-platform.vercel.app
6 stars 4 forks source link

Change depositPct to requiredDeposit #103

Closed deweller closed 2 years ago

deweller commented 2 years ago

Integer math causes off-by-one errors.

We should just store the requiredDeposit in the contract and not a percentage of the bounty.

vercel[bot] commented 2 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

platform – ./frontend

🔍 Inspect: https://vercel.com/engineerdao/platform/TyirB4AYq2y7FHe1kMBYrRMvnSzm
✅ Preview: https://platform-git-issue-102-do-not-store-deposit-pct-engineerdao.vercel.app

backend – ./backend

🔍 Inspect: https://vercel.com/engineerdao/backend/6r6wwP48H1tNJxHyHSL6UfQavqZ3
✅ Preview: https://backend-git-issue-102-do-not-store-deposit-pct-engineerdao.vercel.app

deweller commented 2 years ago

Closes #102