Closed deweller closed 2 years ago
I agree with all except these:
COMPLETED_TIMEOUT_SECONDS
should not exist. The engineer is paid once the timeout completes. Otherwise its a weird arbitrary timeout.MINIMUM_DEPOSIT
is too high. Do we need this to be over $1 or token equiv? So long as the bounty is > $50, we shouldn't have a problem with the resolution fees.Still not 100% on the reporting stuff. Seems we may have trouble with that whole system. I wonder if, for MVP, we just do it manually? As in - our multisig can close contracts, after a "soft report".
Here are the current values in the latest contract.
// 50 paymentTokens ($50)
uint256 public MINIMUM_BOUNTY = 50e18; // $50
// 50 paymentTokens ($50)
uint256 public MINIMUM_DEPOSIT = 50e18; // $50
// 10%
uint256 public DAO_FEE = 1000; // 10%
uint256 constant MAX_DAO_FEE = 2500; // 25%
// 6%
uint256 public RESOLUTION_FEE_PERCENTAGE = 600; // 6%
uint256 constant MAX_RESOLUTION_FEE_PERCENTAGE = 2500; // 25%
// Number of seconds after job is completed before job is awarded to engineer
uint256 public COMPLETED_TIMEOUT_SECONDS = 7 days;
uint256 constant MIN_COMPLETED_TIMEOUT_SECONDS = 3 days;
uint256 constant MAX_COMPLETED_TIMEOUT_SECONDS = 30 days;
// Deposit required to report a job
uint256 public REPORT_DEPOSIT = 50e18; // $50
uint256 constant MIN_REPORT_DEPOSIT = 10e18; // $10
uint256 constant MAX_REPORT_DEPOSIT = 200e18; // $200
// 10% - Reward of the bounty given to a successful reporter
uint256 public REPORT_REWARD_PERCENT = 1000; // 10%
uint256 constant MAX_REPORT_REWARD_PERCENT = 2500; // 25%
Please ack or noack for MVP launch.
10% (max 25%) seems a little high for the DAO fee to begin with. I suggest 6% (max 15%) for launch.
And let's change MAX_RESOLUTION_FEE_PERCENTAGE to 15% now that I look at it again.
On Discord we decided on a 3% fee to launch with.
The following values should be decided: