brtwrst
commented
2 years ago Neat Idea. I'm not sure I really want to include that right now. I was not able to test it because of some error during the installation of guesslang. I tried on Windows and linux.
As to the PR in general, not specific to our repo:
- State what your PR does in a clear and concise manner. I had to read the code and look up what guesslang is to find out what you're trying to do.
- Including the autoformatting in the same commit as your actual changes makes it hard to see what is really new and what is not. The repo readme states autoformatter and settings to be used when contributing. Always make clear and easy to understand commits.
- Saying
the code probably doesn't workmeans you didn't test it and expect us to do your testing and final implementation for you. So this is basically an enhancement suggestion packaged as a PR instead of a Issue/Discussion. Always test what you are proposing.
All these things feel a little bit like you don't respect the time of the maintainers (even though you surely didn't intend that) so maybe try to avoid these points when opening PRs in the future.
Other than that i think the code might have worked if the installation of guesslang didn't error out - i can't see anything obviously wrong with it.
I'm very new to python and decided I wanted to improve my knowledge by trying to add a feature to this bot. Regardless of that, I don't understand 99% of the code in it, but I tried my best. I'm pretty sure the code I wrote doesn't work but I think you'll get the main idea of what I'm trying to do. You'll have to rewrite my code in another commit. Oh and sorry for the mess my formatter did, it ain't much tho.