search

engineer-man / piston

A high performance general purpose code execution engine.
https://emkc.org/run
MIT License
1.89k stars 238 forks source link

Github actions npm and node version #571

Open lorypelli opened 1 year ago

lorypelli commented 1 year ago

As I saw when making pull requests, npm version is 7.x.x also if 9.x.x exists and node version is 15 also if 19 (but I recommend 18) exists

HexF commented 1 year ago

Feel free to submit PRs to update them throughout

lorypelli commented 1 year ago

Feel free to submit PRs to update them throughout

idk how to update npm version at all

lorypelli commented 1 year ago

for nodejs I tried submitting a pr but I closed it (idk if it was working)

HexF commented 1 year ago

They are included in the base docker container iirc.

lorypelli commented 1 year ago

They are included in the base docker container iirc.

https://github.com/engineer-man/piston/pull/578

lorypelli commented 1 year ago

They are included in the base docker container iirc.

Is there a file on the repo?

HexF commented 1 year ago

They are included in the base docker container iirc.

Is there a file on the repo?

https://github.com/engineer-man/piston/blob/master/api/Dockerfile

lorypelli commented 1 year ago

They are included in the base docker container iirc.

Is there a file on the repo?

https://github.com/engineer-man/piston/blob/master/api/Dockerfile

Are you able to update node and npm?

lorypelli commented 1 year ago

@HexF any updates...there is also node 20 now and node 15 isn't supported anymore (now node 18 is LTS so I recommend upgrading) also npm version if possible...