Open RichiCoder1 opened 3 years ago
Hi, and thanks for opening this issue!
Why would version automatically become "latest"?
Mostly to have a default in place, though I'd be fine leaving that out to force consumers to think about versioning and pinning the version.
Ok, that makes sense. As long as it's clear in the documentation (readme for now) that the URL location and repository can be disconnected (i.e. in a lot of cases, the binary assets are stored in some cloud accounts), I'm ok with this change.
Would you be interested in contributing? I'm happy to help / review, but it would probably take me a few weeks to get back to adding this.
The changes seem to be when we make the decision to get a GitHub release -- here we would change the condition to test for a urlTemplate
as well, then try to infer the GitHub repository:
I can def contribute that :)
Done! Lmk if it looks good: https://github.com/engineerd/configurator/pull/30
Having used this action a few times now, I think there's some possibility to make the action a bit less boilerplate-y.
Specifically, if the user specifies a
urlTemplate
that matches^https:\/\/github\.com\/(?<repo>.*\/.*)\/releases\/download\/
, infer the following:So that this:
would become this: