engineerd / wasm-to-oci

Use OCI registries to distribute Wasm modules
Apache License 2.0
251 stars 31 forks source link

Test and add AWS ECR to the list of supported registries #18

Open radu-matei opened 3 years ago

radu-matei commented 3 years ago

According to this blog post, AWS ECR should have support for storing OCI artifacts, meaning it should accept Wasm modules as well. We should test that this is the case, then add it to the list.

If anyone with an AWS account wants to test it, that would be great!

deepu105 commented 2 years ago

I can test this

mreferre commented 2 years ago

I came here to post an issue to track a potential PR and I found this one. Cool.

I have tested it a few minutes ago and it (seems) to work just fine:

$ aws ecr get-login-password --region us-west-2 | docker login --username AWS --password-stdin 693935722839.dkr.ecr.us-west-2.amazonaws.com
Login Succeeded

$ wasm-to-oci push python3.wasm 693935722839.dkr.ecr.us-west-2.amazonaws.com/python3.wasm:latest  
INFO[0009] Pushed: 693935722839.dkr.ecr.us-west-2.amazonaws.com/python3.wasm:latest 
INFO[0009] Size: 26193349                               
INFO[0009] Digest: sha256:6e723ad57cadd700e0fed37aa62b0dbe973af7597efaabac4265ad53ff90901e 

$ rm python3.wasm 

$ wasm-to-oci pull 693935722839.dkr.ecr.us-west-2.amazonaws.com/python3.wasm:latest --out python3.wasm 
INFO[0010] Pulled: 693935722839.dkr.ecr.us-west-2.amazonaws.com/python3.wasm:latest 
INFO[0010] Size: 26193349                               
INFO[0010] Digest: sha256:a29013c02f0b76edbf2d7f57ca2f60c71cf33925119ebd3f7fb8c1d8c313386d 

$

PS the subject of this issue says ECS but it should really say ECR PS2 also note that the 693935722839.dkr.ecr.us-west-2.amazonaws.com/python3.wasm repository needs to exist because ECR does not (yet) support create on push.