search

engineerjoe440 / ElectricPy

Electrical Engineering Formulas in Python
https://electricpy.readthedocs.io/en/latest/
MIT License
86 stars 16 forks source link

Induction Motor Circle and IC 555 #13

Closed Lakshmikanth2001 closed 3 years ago

Lakshmikanth2001 commented 3 years ago

I tried to include the required docstring in the InductionMotorCircleDiagram class, I am not sure whether you will be happy with

the ic_555 function, but I am unable to understand how exactly should I spilt the function and I even tried to include all the minor

changes which you have suggested me in the previous pull request, Thank you very much sir

engineerjoe440 commented 3 years ago

@Lakshmikanth2001 This looks terrific!!! Thank you for your hard work! I've been running a bit wild this week, and still haven't had a chance to fully review this. It looks like there's some form of issue with the documentation, it looks like it's not passing the pydocstyle check. I'm not exactly sure why. Will have to investigate. More than likely it's something small that I can fix once we merge this in.

I'll plan to sit down tomorrow evening and review your hard work. Thank you again!

Lakshmikanth2001 commented 3 years ago

Thank you very much , but still I am not sure about the way you wanted ic_555 function I will try to improve and add more functionalities thank you