search

engineerjoe440 / ElectricPy

Electrical Engineering Formulas in Python
https://electricpy.readthedocs.io/en/latest/
MIT License
86 stars 16 forks source link

Added Power Circle , Improved Testing Function #36

Closed Lakshmikanth2001 closed 2 years ago

Lakshmikanth2001 commented 2 years ago

Sir, I have tried to made all the changes which are suggested, please review my work and give your valuable feed back

Lakshmikanth2001 commented 2 years ago

Sir, Please review my above changes and give your valuable feedback

Lakshmikanth2001 commented 2 years ago

Sir any updates

Lakshmikanth2001 commented 2 years ago

Sir any updates ????

Lakshmikanth2001 commented 2 years ago

I have already adjusted line wraps and imports in this already in https://github.com/engineerjoe440/ElectricPy/pull/36/commits/f04c680cec0424d551886f0946d2753cb6e33383 and https://github.com/engineerjoe440/ElectricPy/pull/36/commits/a7b7b7267f083e4ca5ab7a409c9a04aa1aced2f2 please checkout that

engineerjoe440 commented 2 years ago

Interesting... seems that GitHub was not showing me the diff correctly. I will re-review and let you know what I find.

engineerjoe440 commented 2 years ago

Ok! After further review, here are the remaining items that I think still need to be addressed: